Repository navigation
feat(libSceLibreSsl3): accept NULL in PKCS7_free, PKCS8_PRIV_KEY_INFO_free and OCSP_CERTID_free - #16111
Open
MarrasFederico wants to merge 3 commits into
Open
feat(libSceLibreSsl3): accept NULL in PKCS7_free, PKCS8_PRIV_KEY_INFO_free and OCSP_CERTID_free#16111MarrasFederico wants to merge 3 commits into
MarrasFederico wants to merge 3 commits into
Conversation
…_free and OCSP_CERTID_free
github-actions
Bot
added
build
docs
prx
needs rebase
This was referenced Nov 5, 2026
github-actions
Bot
added
needs rebase
github-actions
Bot
added
needs rebase
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PKCS7_free,PKCS8_PRIV_KEY_INFO_freeandOCSP_CERTID_freein libSceLibreSsl3 threw for every call, NULL included. Cleanup code usually calls these on pointers that may still be NULL. In LibreSSL 4.0.0 each one isASN1_item_free, which returns at once for NULL.All three now return without action for NULL. A non-null object still throws: this module has no constructor for these types (
d2i_PKCS7,d2i_PKCS8_PRIV_KEY_INFO_bioandOCSP_cert_to_idare unimplemented), so no such object can be released correctly yet.Export.cpptosrc/Asn1Free.cppwithvoid (void*)signatures, as in LibreSSL.Not measured on a console.
Tested
Ubuntu 26.04.1, kernel 7.0.0, GCC 15.2.0, Release,
BUILD_TESTING=ON, on main6e6dae4e8b. Windows and macOS were not compiled here. No title was run.guest_libressl3_asn1_freepasses: each function returns for NULL without throwing. All 14 LibreSSL3 tests pass.(void)declarations, and the placeholders throw.check_conventions.py --base upstream/mainpasses.pr_overlap.py: several open LibreSSL3 PRs (#15631, #15737, #15758, #15760, #15761, #15765, #15770, #15899) and my #15599 and #15601 touch the same CMake, header and pending-export lines; none implements these three functions (searched by name in open PRs).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)